efcore
efcore copied to clipboard
dotnet
Implement ExecuteUpdate
Will be iterating over this PR. Wanted to get it out for review because I added docs for everything (and new exception points for ExecuteUpdate). Thanks for the review on those.
I will be adding more test, at least covering the same scenarios as Delete and few more for EF.Property/EF.Default/Multi-property.
Wrt pushdown into subquery, it is not that straightforward for update, as the values could be using values from other tables, so if we push it down into subquery like Delete then we don't have access to those values. Trying to think of some way to rewrite to get filtering and values both.
Pending items, EF.Default & allowing joins & converting unsupported structure.
Hello @smitpatel!
Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.
p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
- Azure Pipelines
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.
Give feedback on this
From the bot dev team
We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.
Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.
This is a very very important feature. I have been using it since day 1. Made our life much much easier along with ExecuteDelete Thank you EFCore team
Thanks for the positive feedback @pantonis, really good to know that this is useful for people!
