Sean McGivern
Sean McGivern
Please do; it's not your fault, but Grunt's async API is a) kind of insane (it shouldn't be so easy to break other tasks) and b) hard to debug. @csnover...
> Updated documentation. I'd like to do this, but I wasn't sure where. Maybe https://github.com/rubocop/rubocop-rspec/blob/master/docs/modules/ROOT/pages/upgrade_to_version_2.adoc?
I tested this on a library we have that uses rubocop-rspec and it worked for me: https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/119#note_1092839680
Thanks @pirj, I added some brief development documentation. (Rendered: https://github.com/smcgivern/rubocop-rspec/blob/ad674c8ee2a55a48f933a4605d9145daaa83c7ba/docs/modules/ROOT/pages/development.adoc) I am not sure what the documentation guidelines are here, so I'm happy to take any and all suggestions there.
Thanks, done.
@tdeo thanks for trying it out! I rebased because the CHANGELOG had conflicts, but the workflows need a maintainer to approve before they run:
@pirj sorry for the push spam, I didn't fix the CHANGELOG properly first time around. This is up to date now.
Thanks @pirj! I look forward to deleting this file from our repos when this is release 😃
Thanks for filing the upstream report! I was able to work around this (in a terrible way) by just replacing `tramp-sh-handle-make-process` with the [old version](https://github.com/emacs-mirror/emacs/blob/0820a81ec7a1dcd421b3eec345a38d8405ee00a0/lisp/net/tramp-sh.el#L2808-L3067), using `(advice-add ... :around ...)`...
`.onConflict` also hasn't been replaced in another sense - I don't see a way to do `ON CONFLICT (a, b, ...) DO NOTHING` any more. If we provide `.orIgnore`, we...