grunt-rename icon indicating copy to clipboard operation
grunt-rename copied to clipboard

Handle multiple and expanded sources properly

Open smcgivern opened this issue 11 years ago • 3 comments

done should only be called once, but was called multiple times if either:

  • The src option was set to an array of files.
  • The expand option was enabled and that expanded to more than one file.

This would break future async grunt tasks. The destination would also be set to the same filename for all elements in src arrays, which is fixed in this branch too.

smcgivern avatar Sep 05 '14 10:09 smcgivern

@jdavis could you please either land this and publish a new version or mark this project as dead and not to be used? Introducing the grunt-rename task into a project breaks the build because of this issue.

csnover avatar Feb 11 '15 18:02 csnover

I don't use Node much anymore; I'll probably just deprecate this as I'm spread too thin.

jdavis avatar Feb 12 '15 01:02 jdavis

Please do; it's not your fault, but Grunt's async API is a) kind of insane (it shouldn't be so easy to break other tasks) and b) hard to debug.

@csnover if you really want this plugin, you can use my branch in your package.json. We are using it for production builds and it works for us :smiley:

"grunt-rename": "git://github.com/smcgivern/grunt-rename.git#support_src_arrays"

smcgivern avatar Feb 15 '15 11:02 smcgivern