Steffen Jaeckel

Results 201 comments of Steffen Jaeckel
trafficstars

> As salsa20 was not released yet (it is only in develop branch) we can still change its API if needed yep > e.g. incorporating salsa20_ivctr64 into salsa20_setup or/and introducing...

The AppVeyor builds show them as well...

> What about adding `/WX` (= treat all warnings as error)? as soon as they're fixed, sure - why not!

Looking at these it also became obvious to me that there's different paradigms used for different classes of algorithms... like the `XXhash_done()` functions always use the same signature as `pelican_done()`...

no worries, I already had a look at that finding because I was like "come on, this can't change anything in the generated code" ... aaaand I was wrong ......

Well, the documentation already states the following: https://github.com/libtom/libtomcrypt/blob/06a81aeb227424182125363f7554fad5146d6d2a/doc/crypt.tex#L828 Looks like that isn't sufficient, maybe could require a bit more clarification. Implementing the full spec would also be an option. I'll...

PBKDF2 is available, but it's called [pkcs5](https://github.com/libtom/libtomcrypt/blob/develop/src/misc/pkcs5/pkcs_5_2.c)

I agree that this is not consistent, but I'm not entirely sure what the correct solution should look like ... I'm tempted to argue in a very different than you...

Just a question beforehand: I'm not 100% sure, but AFAIU `LTC_MECC_FP` makes timing attacks even easier, right?

> I do support this idea; however, this is going to break a lot of things. Basically nearly all SW using libtomcrypt. yep, one has to break stuff sometimes to...