Steffen Jaeckel comments

Results 201 comments of


                                            Steffen Jaeckel

trafficstars

An improper locking bug(e.g., deadlock) on the lock ltc_ecc_fp_lock

btw. referring to https://github.com/OP-TEE/optee_os/pull/4842 would have been nice :) looks fine, I'll apply the patch you posted to optee

README on MPIs

Sorry, it true... you're not the first ones who had those problems... but I don't really know how to describe what is missing as information. Now that you've figured out...

ecc_verify_hash_raw fails when not using Shamir method and provided hash is all zeros

@karel-m how should we proceed with this issue regarding the release?

An attempt to fix #449 (ECDSA forcing DER/ASN.1)

so we wait now until the two missing points are done?

An attempt to fix #449 (ECDSA forcing DER/ASN.1)

:+1:

Cast STORE64H/STORE64L argument to ulong64

IMO this cast belongs in the calling code and not in the STORE macro. Those macro's clearly say that they store a 64bit Variable and if you pass a 32bit...

reported build issues with mac os 10.12.6

> seems both tomsfastmath and libtomcrypt typedef ulong64, which is not quite conforming. maybe it'd be a good idea to add a #define ULONG64_DEFINED and only do the typedef if...

reported build issues with mac os 10.12.6

> ... but as i do not have access to a mac, i can't tell for sure ...neither do I. @wiire-a you gave a :+1: to the issue, can you...

Support for latest libtomcrypt

c.f. https://github.com/libtom/libtomcrypt/pull/596 which should make it easier to update ltc

Improve mp_root_n code

@czurnieden could you maybe have a look if you have the time? You've added parts of the removed code in 984d3ff67990209285b454c189d9a90181ee41ca and I'm not sure whether this should/can really be...