Steffen Jaeckel

> ``` > #define mp_isone(a) ( ((a)->used == 1u) && ((a)->dp[0] == 1u) ) > ``` > > That macro is not in `tommath.h` or `tommath_private.h`. Should it? I don't...

Sorry @ssinai1 for highjacking your PR for this discussion :) I've created #537 for that purpose now. We should continue with this question https://github.com/libtom/libtommath/pull/532#issuecomment-1228932509 now :) (and by 'we' I...

> AFAIK @sjaeckel plans to improve some parts of this PR with @techmetx11, so setting review on him. I don't have the time for a deeper review and I don't...

@davidbernard04 that's caused by internal changes of libtommath where previously the prime verification simply wasn't as good as it is now... and this comes at a speed penalty. tl;dr -...

> @sjaeckel just to confirm, ecdsa doesn't seem to need primality testing at all does it? Correct, primality testing is only required for RSA and DSA.

This should be fixed now. Please update to 1.3.0 and report any potential bugs by opening a new issue or post other questions to that release in https://github.com/libtom/libtommath/discussions/575

I'm closing this as there was no action for too long. Please re-open if you have further questions/comments/improvements and still want this to be merged.

Closed via #505

Cool, could you please take develop and check whether a release would be fine?

Could you please list all ABI breaks so we can check whether it'd make sense to take the effort to backport and release another version of `libtommath.so.1`? ... and at...