Steffen Jaeckel

Results 201 comments of Steffen Jaeckel
trafficstars

Re-opened as #331 has its base to a non-existant branch now

c.f. https://github.com/libtom/libtommath/pull/331#issuecomment-526922246 > Snprintf should not be used. what else? btw. I can't reproduce the error (yet) c.f. https://github.com/libtom/libtommath/pull/331#issuecomment-526863425 > how does this look? looks fine IMO, I'll have a...

> > how about leaving mp_todecimal as a macro and calling s_mp_todecimal_fast() from mp_to_radix() if the radix == 10? > > Not possible since MP_HAS is only available privately and...

> > Snprintf should not be used. > > Instead you should convert the number to a string "by hand". It does not make sense to call out to a...

> Would it be possible to get the generalized version for arbitrary bases replacing the current impl? let's first get this one finished by @MasterDuke17 and then we'll have a...

I only found https://github.com/libtom/libtommath/issues/48#issuecomment-175081513

We should probably discuss with @nomeata what will solve his problem, because IIUC creating a `mp_expt_long()` or similar won't solve it. Or am I wrong?

C.f. https://github.com/libtom/libtommath/pull/525#issuecomment-1037980954

I just wanted to say "I think there are even more currently public functions which could be private" but after having a look it seems like there's only the reduce...

your opinion? @czurnieden @nijtmans @karel-m