Simon Plenderleith
Simon Plenderleith
@pstadler Thanks for opening this PR — it looks great! I'm going to check out the branch and give it a manual test before merging. Please can you add a...
@pstadler I've been quite overloaded recently, so haven't been able to give this the testing time it needs. Thanks for being so patient, I'll do my best to pick it...
**Manual testing** - [x] Test against a JavaScript application - [x] With default Ajv instance - [x] With custom Ajv instance - [ ] Test against a [TypeScript application](https://github.com/simonteaching/api-project/) -...
@pstadler I've run into an issue while manually testing this PR, but I'm not quite sure what's going wrong: I've created a minimal JavaScript application ([code](https://gist.github.com/simonplend/7123f4842fb5795cd3e0d225b217d722#file-server-js)) and then installed `ajv`...
From what I can tell, this `instanceof` check isn't working: https://github.com/simonplend/express-json-validator-middleware/pull/116/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R11 I've confirmed that with a minimal reproduction too: ```javascript const Ajv2019 = require("ajv/dist/2019"); const AjvCore = require("ajv/dist/core").default; const ajv...
> Your check is wrong, you need to replace: Good catch on the bug in my minimal reproduction. I made the replacement you suggested and it was `true` as expected....
Hi @w473 :wave: I'm the new maintainer of this project. Thank you so much for your contribution! This looks like a really nice feature addition. I'm currently working on the...
@w473 Great, thank you :+1:
@NGTOne Thanks for raising this issue - the rationale you've provided for this feature is sound. I agree that it's not a good practice to mutate the request object. The...
> > My one concern with this proposal is the need to be especially careful with Express and Promises, given that Express does not have out-of-the-box support for handling rejected...