express-json-validator-middleware icon indicating copy to clipboard operation
express-json-validator-middleware copied to clipboard

Published 20 hours ago • verified publisher icon simonplend

Possibility to use predefined schema for all validation checks (new ajv version as well)

Open w473 opened this issue 4 years ago • 3 comments

w473 avatar Jan 11 '21 14:01 w473

Hi @w473 :wave: I'm the new maintainer of this project.

Thank you so much for your contribution! This looks like a really nice feature addition.

I'm currently working on the v2.2.0 release, but I'm intending to upgrade Ajv to v7 in a v3.0.0 release. In regard to this pull request:

  • I want the upgrade to Ajv v7 to be in its own pull request as its own clear set of changes. When I start working on the v3.0.0 release I will create a pull request which only contains the upgrade to Ajv v7 and references you introducing the upgrade in this pull request (the ajv-formats note you have added in the README is :+1:).
  • Once I've merged in the pull request for upgrading to Ajv v7, would you mind creating a new pull request containing only the predefined schema changes?

I think potentially all of the changes you've proposed here could go in the v3.0.0 release, but I would like to separate things out so they can be released separately if needed. It will also make for a cleaner history in git.

simonplend avatar Jan 19 '21 15:01 simonplend 

* would you mind creating a new pull request

sure, no problem. I will then wait for 3.0.0

w473 avatar Jan 19 '21 20:01 w473

@w473 Great, thank you :+1:

simonplend avatar Jan 19 '21 22:01 simonplend