silverwind

Results 1256 comments of silverwind

> I would also argue that we shouldn't be able to set a due date on a merged PR since to my knowledge users would only use this feature to...

Maybe use either https://github.com/ProtonMail/go-crypto or https://github.com/ProtonMail/gopenpgp?

Seems they fixed it in https://github.com/ProtonMail/go-crypto/pull/175, no? Long-term, it's very much preferable to depend on a supported package, ideally with some tests to confirm the signatures work, as just from...

Are there any tests covering the audit log output? Not, I only skimmed the changeset, but could not see such tests.

> I think we should not store the audit log to files because it's difficult to filter via different conditions. i.e. date range, actors, ips, actions and etc. We have...

@KN4CK3R can you show a sample how the log format looks currently? I guess the file could serve as a starting point and yes, in a properly set up distributed...

Nice, I like it. I guess it shouldn't be too hard to add a database table for it later, nested fields or the whole entry could be stored in a...

> That is for some bigger instances or an expert users. For most Gitea instances, if they want to filter logs, they need to install many other tools if the...

Do we accept filling the DB here as well without any UI? I would imagine if UI is in scope for this PR, it will get too complex.

The per-unit UI that shows the audit log. E.g. in Repo there would be a "Audit Log" in the Activity menu to show all changes done to the repo. Good...