silverwind

Results 1221 comments of silverwind
trafficstars

It seems that whitespace is rendered twice. Simple repro: ```` key: | value ```` HTML of second line: ````html value ```` The 2 spaces are rendered highlighted once inside the...

I think it would be a good test case to verify whether the [`textContent`](https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent) of the HTML output matches the input code exactly. With such a test, bugs like double...

This is ready in the sense that it doesn't throw JS errors anymore. What remains to be done: - Check if all JS features work. - Maybe restrict certain tooltips...

> Would be nice to make it accessible using aria attributes It already sets the [tooltip](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role) and [menu](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role) roles on the tippy instances. What else do you have in mind?...

Still a few things untested: - commit status popup - stopwatch popup - tooltip widths

This should be ready to review/merge. At least I don't find any more issues.

Ah, I may have missed that popup, checking.

https://github.com/go-gitea/gitea/pull/20736 to fix this popover.

> And here (commit history) it seems better to make the popup shown on the ~right~ top or bottom. > > ![image](https://user-images.githubusercontent.com/2114189/183695730-4928108b-a8e1-4d80-88f5-94dea188d6b8.png) I tend to agree that top/bottom is probably...

https://github.com/go-gitea/gitea/pull/20737 is the actual fix, I split up that PR.