silverwind

Results 1267 comments of silverwind

If there is a hypothetical function `writeAuditLog(entry)` that is called whenever a entry is generated, first write it to file, then write it to db, maybe even concurrently. Never read...

- Filename seems to conflict with uploaded file. Do we require a certain naming pattern? - The file input should look like the text inputs, e.g. label before, a break...

What do those package filenames look like? I assume they are different per type of package? Maybe we can keep things simple and just auto-generate a filename from name and...

Oh and the input placeholders in UI should show sample values, e.g. `1.2.3` for version for example.

UI looks good, but I would replace "The Package:" with "File:"

Here is my ruleset in case it matters. It happens while linting a OpenAPI 3.0 file. ```yaml extends: [[spectral:oas, all]] rules: contact-properties: off info-license: off license-url: off oas3-api-servers: off oas3-parameter-description:...

It is a runtime deprecation in Node.js, these only log when actual code is being ran. The dependency trace above shows it's coming from `node-fetch`, so I guess in your...

See https://nodejs.org/api/deprecations.html#dep0040-nodepunycode-module: > v21.0.0 Runtime deprecation. > v16.6.0 Added support for --pending-deprecation. > v7.0.0 Documentation-only deprecation.

Yeah, I guess variable reassignment might be tricky to detect in static analysis.

There is one more incorrect readonly checkbox, last line here: ``` $ rg checkbox.+readonly templates/repo/migrate/gogs.tmpl:106: templates/repo/migrate/gitlab.tmpl:103: templates/repo/migrate/onedev.tmpl:92: templates/repo/migrate/github.tmpl:106: templates/repo/migrate/git.tmpl:66: templates/repo/migrate/gitea.tmpl:104: templates/repo/migrate/gitbucket.tmpl:108: templates/repo/migrate/codebase.tmpl:92: templates/repo/create.tmpl:53: templates/repo/settings/options.tmpl:33: