silverwind

Results 1257 comments of silverwind

This `--theme-website` would not be inside the media queries. It's metadata that is true for both color schemes, so would be outside. Inside media queries scheme we really only need...

I suggest we rename to `--theme-name`, shorter and more memorable, the other one is the "file name".

> The remote or local theme packages could contain multiple files I would not support multi-file themes, but it's already possible. If user really wants to use multi-file, they must...

My example is complete. Themes that make use of [media features](https://developer.mozilla.org/en-US/docs/Web/CSS/@media#media_features) should declare their general vars outside these `@media` blocks. Here is a example of a theme in my format...

> I have shown my format in https://github.com/go-gitea/gitea/pull/30671#issuecomment-2077995426 , my method does work well, for your new case: Your method would needlessly duplicate stuff like `--theme-name` and `--theme-author` into every...

> My method do not need any extra --theme-author for each media block. See https://github.com/go-gitea/gitea/pull/30671#issuecomment-2079192477 What's the difference in yours? It looks exactly the same to me.

Your only difference is `gitea-theme-meta-info` and I'm still against it as it's a dead selector and therefor inaccessible to JS `getComputedStyle` and completely inaccessible to CSS. It does seem we...

There is now different behaviour after recent changes. Imho we need to switch to a 2-row layout on small viewport.

Seems I've completely missed this, sorry. I think I can give the frontend parts a proper review but I do see multiple areas that will need quite a bit of...

> Maybe we can merge #30170 first. Whichever is ready first will be first and the other will suffer merge conflicts 😆.