gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Notes for Project-Board-Columns

Open zokkis opened this issue 1 year ago • 7 comments

Functionality

  • [x] view, create, edit, move, delete
  • [x] create issue from note - title and content is prefilled
  • [x] support organizations/user projects
  • [x] support for milestone, labels
  • [x] pin notes like issues

Closes #12513 Closes #29029 Closes #29031 Fixes a bug that the wrong cursor was used on column-title

image


This is my first time working with GO, so please be nice and I will try anything to help with this feature

zokkis avatar Feb 04 '24 08:02 zokkis

@gitZokki I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. :tea:

GiteaBot avatar Feb 04 '24 08:02 GiteaBot

After a few more hours I have more questions

  • why are the ids in int64 and not uint64?
  • how should the permission be handled, because currently everybody who has write-permissions to the repo can add and edit notes and pin/unpin them, but only admin can pin issues
  • should the note be deleted when the user creates a issue from a note?

In the feature-request for the BoardNotes there are some things I think are not important to add

  • 'Ability to assign a person' -> no, because you can create a issue and assign the person to the issue and notes should be simple
  • 'priority' -> with the order should the prio be set, there is also the option to pin and add labels
  • '"private" options' -> I don't think its usefull

zokkis avatar Feb 04 '24 16:02 zokkis

Seems I've completely missed this, sorry. I think I can give the frontend parts a proper review but I do see multiple areas that will need quite a bit of work. One question:

image

Why do note cards render these "duplicates" above?

silverwind avatar Apr 19 '24 00:04 silverwind

Maybe we can merge #30170 first.

lunny avatar Apr 19 '24 04:04 lunny

Maybe we can merge #30170 first.

Whichever is ready first will be first and the other will suffer merge conflicts 😆.

silverwind avatar Apr 19 '24 09:04 silverwind

Does this PR contains the fix in #26561?

yp05327 avatar May 09 '24 05:05 yp05327

Please resolve the conflicts, sorry the rename PR results in so many conflicts.

lunny avatar May 28 '24 09:05 lunny