silverwind

Results 1234 comments of silverwind
trafficstars

> preventDuplicates should not default to true, it is a breaking behavior. Ended up following your suggestion and defaulting to `false`, so it requires opt-in at the caller and I...

I'll merge this now for the bugfix part. We can iterate on the toast in https://github.com/go-gitea/gitea/pull/31501.

I can remove the toast code in favor of https://github.com/go-gitea/gitea/pull/31501 if you port all my changes from here (htmx and actions view `preventDuplicates`) into it. I don't really care about...

Ah, I see you went with the "default enabled" variant, so yes in this case we don't need to special-case these callers. I will remove all toast-related code from this...

Sorry, meant to reply. I will rework this later.

FYI https://codeberg.org/forgejo/forgejo/pulls/6122 is related and deals with the same bug of the job step sometimes not expanding.

> I will try to work on it in the following few days, to see whether we could properly fix it in 1.23 Thanks, I haven't gotten around to this....

Yes, that includes the most important fix. As for the other 2 topics, I think we can do them another time.

Tailwind migration done.

This change broke all past versions of air as it's no longer possible to `go install` anything but the latest version where module path matches repo path. Go module system...