silverwind

Results 1225 comments of silverwind
trafficstars

> As for the key comment maybe it can be omitted in unauthenticated requests but included in requests with tokens? I'm looking for just the key material and I'm okay...

Ideally such menus shouldn't be z-fighting with the page elements in first place and this could be achieved by using tippy dropdown instead of fomantic dropdown.

Can't easily split this because if I remove only the toast changes, there would be the problem of repeated error toasts every second because of that refresh mechanism. The only...

BTW one reason we need the toast deduplication: Go to admin dashboard and disconnect your network:

> maybe there should be some tests to cover some functions (even without e2e test, we could mock and test some code blocks) Quite hard I assume unless Vue works...

Will also fix the boolean trap with `loadData` :)

Right, this `createApp + mount` pattern I had a helper function in another PR, so likely tests could use it in place of this `h` function. BTW, I think I...

> force=true will reset other this.loading=true A ideal implementation would detect a `request` with same args and any subsequent calls with those args while a request is already running would...

> > > maybe there should be some tests to cover some functions (even without e2e test, we could mock and test some code blocks) > > > > >...

> it should hide the existing toast, but not skip the new toast. Thought again about this and I think it's not ideal to have a toast constantly re-show. It's...