Ondra Pelech
Ondra Pelech
Awesome, looking forward to having laws for `ForEach`! :smile_cat:
@adamgfraser I know you're super busy and this is not urgent, but once you have the time, could you please have another look at this, please :pray:
@arnoldlacko Seems fine to me :+1: Give it a spin and report back with what you find :rocket: (We've hit some issues with Dotty's type inference with [`orElseSucceed`](https://github.com/zio/zio-prelude/pull/413) but hopefully...
@atrianac `onLeft` and `onRight` make sense :+1: Instead of `identity`, there's already `ZPure.environment` -- would it make sense to add `identity` alias @adamgfraser?
Currently, the type of `make` is ```scala def make(value: A): Validation[String, Type] ``` So we would need to change it to ```scala def make(value: => A): Validation[String, Type] ``` right?...
> I'm not sure if we need to do the by name parameter since we are doing this at compile time but we potentially could. If we didn't do that,...
Sure there is :smiley: `ZValidationFailureException` is 100% the same thing as `ZValidation.Failure`, only a subtype of `Exception`, so it has `log` and whether it is `IllegalArgumentException` or not is immaterial....
Sometimes it's just easier to throw the exception you're given, without necessarily creating a custom exception yourself for such situation. Sometimes creating a custom exception class is just overkill. With...
Those are good news :+1: Less code to write and maintain :laughing: How would we do it in ZIO Prelude then? :thinking:
Would it work like this https://github.com/scala/scala-collection-contrib/pull/18 ?