Ondra Pelech

Results 287 comments of Ondra Pelech

@guymers should this be merged before or after https://github.com/tpolecat/doobie/pull/1789 ?

One specific example that I've just come across where returning `Option[Fragment]` makes live unnecessarily difficult: ```scala sql""" ... ${Fragments.andOpt(emailIsNull, substring)} ... """ ``` You can't interpolate this fragment. It fails,...

The point is to enable backward compatible evolution of `Config`. When we would potentially add a new field to `Config`, we don't want to break binary compatibility. Binary compatibility with...

Are you referring to the access modifier of the constructor of `Config`? Making it `private` doesn't make it private in JVM bytecode, it is actually still publicly accessible in JVM...

> making method private breaking bin compat Of course it breaks :smiley: There's probably a misunderstanding. I know the changes that I'm proposing in this PR are breaking bin compatibility....

@jatcwang so what do you think? Can we merge this?

Did you look into the companion object?

@jatcwang do you think we could merge this PR?

Let me try to summon @kitlangton , maybe he'll be able to help.