Ondra Pelech

Results 287 comments of Ondra Pelech

@valencik the reasoning behind this is that if you have a case class, you can derive from it various useful tools, like for example the `ConfigReader` from PureConfig. Yes, that...

In every company I've worked with, people want/need config case classes like this and have to workaround their lack. Having "official" config case classes directly in the http4s project itself...

Just to be clear, I'm not proposing any breaking change, let alone _removing_ the builders. The builders are more general, and server a little bit different purpose IIUC. The config...

> You can easily change a parameter type in the current builder encoding (assuming there is a mapping from the old one) but doing this for a `case class` will...

Thanks for investigating this with me, I really appreciate it :bow: Thankfully the problem with `fromProduct` is solvable by manually overriding ```scala def fromProduct(p: Product): Person = p.productArity match {...

But that's not a problem with case classes, let alone http4s. That's just a bug in Scala 3 derivation of `ConfigReader` in Pureconfig. It has no support (yet) for default...

Maybe I'm misunderstanding your post, but it's not that it requires us to encode defaults in a specific way, it just doesn't work. But picking up defaults is super important...

Hello again @armanbilge @rossabaker @valencik . Are you guys open to continuing the discussion about this? Do you think we could find a common ground about this?

Would this count as the demo? https://github.com/armanbilge/sandbox/pull/1 MiMa is happy: ``` +personNew/mimaReportBinaryIssues ``` Yes, PureConfig doesn't work with default values in Scala 3. But that's a PureConfig issue, not a...

> I wrote a comment there. Replied there too :slightly_smiling_face: > MiMa doesn't mean we can be confident that it won't crash at runtime But is that really true? The...