Andrew Powell comments

Results 749 comments of


                                            Andrew Powell

fix(*): provide typings for both cjs and es builds

Great addition. Thank you for taking this on (and sorry for the delay in getting eyes on this. I'm in Florida and was hit by two hurricanes in the last...

fix(*): provide typings for both cjs and es builds

Impressive turn-around on that. A few things: - what's the significance of the Node16 vs Node10 directories - just support for `type: module` in package.json? - the `current_package` setup seems...

fix(*): provide typings for both cjs and es builds

@Septh taking a look now

fix(*): provide typings for both cjs and es builds

Looks like CI is failing on Windows. Not entirely sure why, but unfortunately I don't have the time to triage this for you, and we can't merge until that's passing.

fix(*): provide typings for both cjs and es builds

that's probably unlikely, unfortunately. we have a severe lack of active maintainers.

[rollup-plugin-typescript] Re-enable declarationDir outside output file/dir

Thanks for the issue. I'd like to point out that the reproduction you provided is not valid, and that's not entirely cool since we lay out exactly what is. On...

[rollup-plugin-typescript] Re-enable declarationDir outside output file/dir

your argument may be valid, but in a specific context - yours, and a few others. the full request is it was written was to solve a problem that plagued...

Object props cause check and build failures

(Following up from Discord) Thanks for sharing all of this. > Or is there a way to make check and preview use the preview props that I'm not doing? Not...

Contribution to rollup awesome

@egnor would you like a collab invite for this repo?

Contribution to rollup awesome

the contributing guidelines doc is pretty rigid. the big points are: - at least a month old - a good readme - has tests any PRs I reject don't meet...