awesome icon indicating copy to clipboard operation
awesome copied to clipboard

Contribution to rollup awesome

Open jacobbogers opened this issue 1 year ago • 2 comments

Its about this issue i raised while back

Hello, just decided to circle back and see whats up, yes I found the issue I have 2 emails on github and I noticed as my "primary" does not exist anymore, I have updated my settings, so if you send an invite it should be ok

Eager to help out.

jacobbogers avatar Oct 17 '24 17:10 jacobbogers

I saw an expired invitation on this repo this morning , seems github is flushing some notifications,.., I am paying close attention now...

jacobbogers avatar Oct 18 '24 08:10 jacobbogers

Still checking

jacobbogers avatar Oct 19 '24 11:10 jacobbogers

@shellscape I'm also happy to help work through the backlog of contributions here, I think it's a low risk volunteer thing to do and we will all benefit from having things be updated and new fun stuff entered!

(I don't actually know how many people use Rollup and its plugins directly, though of course many many people use it indirectly under Vite and the like)

egnor avatar Jan 22 '25 22:01 egnor

@egnor would you like a collab invite for this repo?

shellscape avatar Mar 05 '25 14:03 shellscape

@shellscape sure! what expectations do you have for review, etc?

egnor avatar Mar 05 '25 17:03 egnor

the contributing guidelines doc is pretty rigid. the big points are:

  • at least a month old
  • a good readme
  • has tests

any PRs I reject don't meet those. there are some other guidelines in the doc worth taking into consideration too.

shellscape avatar Mar 05 '25 17:03 shellscape

~~cool. I'll go through the current log of PRs and see if I can vet them and roll them into an, uh, omniroll?~~

(@jacobbogers sorry to hijack your own request; did you ever get your access sorted?)

[edit] OK I went through the backlog of PRs. I closed out most of them with a question or request, and asked the submitter to reopen as needed. In a couple cases I pinged @shellscape for guidance since I wasn't clear whether the item in question would belong in this list.

These seem merge-worthy:

  • https://github.com/rollup/awesome/pull/125
  • https://github.com/rollup/awesome/pull/138

I'll wait for @shellscape's input, otherwise just merge those two in a few days, and of course we can look for people who do re-open the older requests. In general looking through the list we could probably do some culling of now-stale/unmaintained/superceded entries...?

egnor avatar Mar 11 '25 00:03 egnor

(I'm going ahead and merging those two, and others that seem reasonable. @shellscape yell at me if I'm going about this wrong)

egnor avatar Mar 18 '25 01:03 egnor