Andrew Powell

Results 749 comments of Andrew Powell

Can we please get this merged? This resolves an error with my project as reported here https://github.com/shellscape/jsx-email/issues/257

@thibautsabot [email protected] was just released today that contains an important fix for windows absolute paths.

@benmccann looks like you missed an edge case here. please take a look.

@benmccann if it's a upstream issue reverting the change until we can get the tinyglobby issue resolved is probably the wise play here.

Good to know. We'll give it a day to see if anyone can step in and if not I'll revert.

@bearfriend not opposed to it in the plugin. we'll want a regression test for this car as well.

Making the decision to revert the changes. The only tangible benefit was a reduction of dependencies, but the juice isn't worth the squeeze.

Didn't expect that! I'll check it out.

We have a big project ahead with going ESM for all plugins - Node 18 is now out of LTS and 20 and 22 support clean ESM require in commonjs.

think about it carefully:)