Ryan O'Hara-Reid

Results 66 comments of Ryan O'Hara-Reid

- [x] websocket reconnection is broken, need to investigate. Something to do with ping handlers not being cleaned up. 🪦

> * [ ] websocket reconnection is broken, need to investigate. Something to do with ping handlers not being cleaned up. 🪦 nevermind that was bad code from me. ![image](https://github.com/user-attachments/assets/789c8dc6-57e9-44e3-bce6-ae43628bfe19)

@cranktakular > * When running all exchange tests, I got an error in okx I didn't get on master (line 333, TestGetBlockTrade, "0 is not positive%!"). Find out whether that...

> Got some more changes I want. > > In addition to those comments, I'm pretty sure these functions could get more test coverage: handleSpotSubscription, wsHandleAuthenticatedData, handleNoTopicWebsocketResponse, wsProcessOrder, getPairFromCategory, Setup....

> Initial bigger architecture comments: > > * reporter doesn't feel like it should be in stream. > We're create "websocket metrics" but I think we should have "metrics, of...

Closed but will keep this updated with trading branches until #2026