Ryan O'Hara-Reid

Results 66 comments of Ryan O'Hara-Reid

> > higher probability of improved websocket message handling > > 👀 _well does it?_ Otherwise remove such a claim from your description 🚨 > > Cool stuff otherwise It...

Opted to label this as medium priority to highlight that it's complementary to #1420 and it's updates. This does not necessarily need to be merged first but it reduces a...

Can you please add more details of the error if you can?

In the meantime you can hook directly into [package level method](https://github.com/thrasher-corp/gocryptotrader/blob/master/exchanges/gateio/gateio.go#L2200) if needed. example: ```go e, ok := exch.(*gateio.Gateio) if !ok { panic("sad") } pair := currency.NewPair(currency.BTC, currency.USDT) pair.Delimiter =...

Might be, have to monitor, the data channel is blocked. In `TestMain` we set the websocket datahandler buffer to 500 that might be something to do with it, might be...

Another consideration is websocket channel data after unmarshalling should be single items only not slices that is easier for consumers to munch on. So for example we usually send a...

> I'm generally unhappy with needing to do any of this ![image](https://github.com/user-attachments/assets/fd4eacf7-e971-4145-aa2f-bc39cb0424aa)

@cranktakular most nits addressed thank you!

@cranktakular Still have more things to do but time constrained hold off on reviewing this just yet until I can get around to it.