Ryan O'Hara-Reid

> Nice works! > > while running websocket: > > ``` > [ERROR] | WEBSOCKET | 01/10/2025 12:43:28 | exchange Poloniex websocket error - connection URL:[wss://ws.poloniex.com/ws/v3/public] error: unexpected end of...

low priority change; stale

> I'm leaving these as comments. If you resolve them, I'll approve. While this doesn't impact things now, its concern for the other PRs/future things which we cannot see/review from...

Most critical items where added in multi currency this can be closed as it's a time issue with reviewing and doesn't add anything in terms of expanded functionality or bug...

This now requires dependency #1733 for spot trading rate limits

removed label because test fix was included in [recent commit](https://github.com/thrasher-corp/gocryptotrader/pull/1598/commits/9c56cbb413e7bca41aa42340d896cc10cb686561)

> This first comment from me covers the overall architecture. Thanks for the suggestions. I appreciate the thought you've put into the overall architecture and the proposed changes you outlined...

> https://github.com/shazbert/gocryptotrader/blob/6376a12b18b7db8ab6d7ab68864af89e8ab06342/exchanges/okx/okx_websocket.go#L254 > > This function is very similar to WsConnect, so it might be a good idea to treat WsAuth as a single connection and use the SetupConnection method...

> https://github.com/shazbert/gocryptotrader/blob/6376a12b18b7db8ab6d7ab68864af89e8ab06342/exchanges/stream/websocket.go#L901 > > Just something to consider for the next round of improvements: we can eliminate these methods by treating each connection as a single instance. This instance can...

> Thank you for adding this. I would just like to see a test from gateio_test.go along similar lines to this: [#1601 (comment)](https://github.com/thrasher-corp/gocryptotrader/pull/1601#discussion_r1798683818) which would allow for your changes to...