Shane F. Carr

Results 2060 comments of Shane F. Carr

On LocaleFamily: currently we have - `with_descendants(en-001)` = und, en, en-001, en-GB - `without_descendants(en-001)` = und, en, en-001 - `single(en-001)` = en-001 I suggested `include_und` be its own option, but...

@robertbastian I want to propose the following narrow changes to the API in order to improve brevity... these would be impacting 2.0, not 1.5: 1. Change `with_locales_and_fallback(...)` to `with_locale_families(...)` instead...

This issue is mostly done in #4710. Known follow-ups in the 1.5 timeframe: - [x] Add BaseLanguageHandling: https://github.com/unicode-org/icu4x/pull/4836 - [x] Add a way to remove `und` via LocaleFamily - [...

```rust "properties": { "chars": { "$ref": "#/definitions/ZeroVec" }, "nested_numbers": { "$ref": "#/definitions/VarZeroVec" }, "nums": { "$ref": "#/definitions/ZeroVec" }, "strs": { "$ref": "#/definitions/VarZeroVec" } }, ``` While technically correct, I think...

In other words, I think my expectation for the JSON Schema of your sample struct would be ```json { "$schema": "http://json-schema.org/draft-07/schema#", "title": "DataStruct", "type": "object", "required": [ "chars", "nested_numbers", "nums",...

Discuss with: - @sffc - @robertbastian - @Manishearth

This PR largely undoes https://github.com/unicode-org/icu4x/pull/2649 The style of returning a wrapped DataError was an explicit choice in https://github.com/unicode-org/icu4x/issues/2639 Also some discussion that included @robertbastian in https://github.com/unicode-org/icu4x/issues/153#issuecomment-1139902832 In general I am...

> Can we have `lengths::Time` and `lengths::ZonedTime`? Otherwise slight preference for option 2. I considered this but it doesn't distinguish between `z` and `zzzz` lengths, which is a fairly big...

Although on second thought we don't distinguish lengths for Month and Weekday, either; we just always include all the lengths by default. I realized that time zones are somewhat similar...

ICU4X WG discussion: - @robertbastian - I like generics when possible, because it gives more structure to the API/the docs. I would be a fan of getting rid of all...