Shane F. Carr

Results 2047 comments of Shane F. Carr

There is a pre-existing CLDR issue to add data for which languages should use Turkic case folding: https://unicode-org.atlassian.net/browse/CLDR-16202

Do you agree with the decision to make the `SinglePlaceholder` marker type be non-constructible? https://unicode-org.github.io/icu4x/rustdoc/icu_pattern/enum.SinglePlaceholder.html https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types

- @robertbastian - this is not 2.0 breaking, they're unstable - @sffc I think it is nice, when we have these types, to hold them back. We an also mark...

Suggested follow-up in https://github.com/unicode-org/icu4x/pull/6401#issuecomment-2773637676 (might be trivial)

Doesn't reproduce for me on Debian, 6.6.15: ``` $ RUST_BACKTRACE=full cargo bench --workspace --all-features -p icu_collections --bench iai_cpt ... Compiling icu v1.5.0 Finished `bench` profile [optimized] target(s) in 1m 05s...

These benches use iai, which says you need to have valgrind installed and working: https://github.com/bheisler/iai

``` $ valgrind --version valgrind-3.20.0 ```