Shane F. Carr

Results 2044 comments of Shane F. Carr

I really want to start the bikeshed for this. Let's focus just on the dynamically sized type that can be infallibly converted from a byte sequence, fallibly converted to a...

ICU4X WG discussion: - @robertbastian - For splitting locales, this seems reasonable. However, ideally we could also split functionality, but that might result in more duplication. - @robertbastian - The...

I investigated this; the only case where we set `None` is in draft PR https://github.com/unicode-org/icu4x/pull/4607

As discussed in https://github.com/unicode-org/icu4x/issues/58, we plan to add a `can_load` function to the DataProvider traits, meaning work can be done on this issue.

I did a bunch more refactoring to reduce the amount of mutation. I agree it makes it easier to follow. Hope you like it :)

@robertbastian Another API proposal. ```rust pub enum LocaleExpansionMode { /// Locales always removed if identical to their parent Deduplicated, /// Locales always retained if explicitly requested or supported Exhaustive, ///...

> it looks harder to reach in an incremental change in 1.5 We can add the two new functions to DatagenDriver and deprecate the old ones. If both the old...

@jedel1043 Thoughts on https://github.com/unicode-org/icu4x/issues/4629#issuecomment-1962219412?

Also note @robertbastian that this design _permits_ baked data to be built with internal fallback in Preresolved and Exhaustive (formerly Hybrid) modes, which is not currently possible.

Naming bikeshed, with some help from Gemini: - The mode currently known as Runtime - `Deduplicated` - `Compact` - `CompactInheritance` (Emphasizes the space-saving aspect and the hierarchical nature of locale...