Shane F. Carr comments

Results 1888 comments of


                                            Shane F. Carr

Reinvent icu_pattern with support for multiple backends

@Manishearth Please suggest how to resolve this error. I am adding a sealed trait based on the design in #4338 which requires `#[allow(private_bounds)]` which isn't on MSRV: ``` error: unknown...

Reinvent icu_pattern with support for multiple backends

Fixed in https://github.com/unicode-org/icu4x/pull/4610/commits/905478610524c614c06fd7d1c69e1be845905c24 based on suggestion from https://github.com/rust-lang/rust/issues/34537

Reinvent icu_pattern with support for multiple backends

The conflict is from 17f2cb091a72efd9ff4812951ff4e3123e9bc513. Accepting mine.

Make code more discoverable by moving component crates to the top level

In general my opinion is being conservative on not changing the locations unless the new location is clearly more logical than the old location. I think there is a decent...

Make code more discoverable by moving component crates to the top level

I don't have an objection to https://github.com/unicode-org/icu4x/issues/4569#issuecomment-1969048536

Make code more discoverable by moving component crates to the top level

Discuss with: - @sffc - @robertbastian - @Manishearth - @zbraniecki

Access to collation elements

@hsivonen thoughts on this?

Access to collation elements

@markusicu Can you weigh in on whether you believe it is advisable to expose this information in ICU4X?

Access to collation elements

Somewhat related: https://github.com/unicode-org/icu4x/issues/2689

Address 122 security alerts

> The number looks bad True, though the alerts are only visible to team members IIUC.] > If they are stupid alerts we should disable whatever reports them, otherwise we...