Shane F. Carr
Shane F. Carr
Fixed by #4628, yes?
I updated the branch to resolve conflicts. I will go ahead and push some additional changes directly to the branch. Then maybe we can get close to merging this :)
Working on getting std-related errors resolved. Next: ``` error[E0152]: found duplicate lang item `panic_impl` --> ffi/capi/src/lib.rs:51:1 | 51 | fn panic(_info: &core::panic::PanicInfo) -> ! { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note:...
Actually looking at how these regexes are used in more detail, they are parsing a fixed pattern string like `"{0}."` which we should be doing in datagen anyway and returning...
@robertbastian suggested an alternate way to make the PR mergeable is to gate the personnames module with the `std` feature
I got rid of some of the regexes. To get rid of the last one, we need MultiPlaceholderPattern.
Big milestone: finally finished migrating all the regexes to `icu_pattern`. Still some internal cleanup work, but the PR is no longer blocked. I would like to merge as soon as...
I'm going to merge this into `icu_experimental` and we can keep iterating from there.
We need more discussion time for this issue. There's not time for 1.3 to have that discussion. It's not a bad enough problem to block 1.3. So this should block...
Discuss with: - @robertbastian - @sffc - (@Manishearth) - (@younies) - @zbraniecki