Shane F. Carr
Shane F. Carr
My understanding is that the proposed set of functions is: - `ceil(position)` - `floor(position)` - `trunc(position)` - `expand(position)` - either `round(position)` or `round_half_even(position)` - optional `round_half_expand(position)` - `round_with_mode(RoundingMode, position)` -...
Also, do we still keep the `-ed` versions? With fewer functions, maybe we can afford to keep them now.
Start: 11:05 - @sffc - I had suggested removing the self-moving functions earlier, but now that we will have many fewer rounding functions, maybe we can keep them because the...
Some background here: The UCD is heavily pre-processed in the ICU4C data build into a form known as `ppucd`. A decision was made early on that it was less work...
Discuss with: - @markusicu - @hsivonen - @eggrobin - @robertbastian - @Manishearth Optional: - @sffc
Is there an opportunity to use a `codepointtrie_builder`-style approach, where we take the core algorithms from C++ and call them from ICU4X via WASM or FFI?
- @robertbastian - Currently ICU4X uses data that is generated from ICU4C. This isn't great because (1) with every update we're blocked on ICU4C, and (2) we're not a clean...
Before I review this, were you aware of https://github.com/unicode-org/icu4x/issues/3257, https://github.com/servo/rust-harfbuzz/pull/197, and https://github.com/servo/rust-harfbuzz/pull/245 when writing this PR?
The data model in this PR: https://icu4x-pr-artifacts.storage.googleapis.com/gha/519c3b32fda1a3c045e00f225da3b8cc6f65dfcc/rustdoc/icu_pattern/struct.NumericPlaceholderPattern.html#pattern-string-encoding-details
Some notes from diving deeper into this with @robertbastian @Manishearth: - Reminder that placeholders could appear in either order (as we had previously discovered) so some sorting needs to take...