Selwin Ong

Results 500 comments of Selwin Ong
trafficstars

RQ has a process that sweeps started jobs and checks whether they’re still alive after their timeout has ended. Jobs that are harvested this way will be marked as failed...

If we want to detect long running jobs abnormally terminating early, we'll need to have a way to check whether the worker running the job is still alive. One way...

I'm happy to accept a PR for this. The newly introduced `Dependency` class gives us a good way of controlling how dependencies are handled. https://github.com/rq/rq/blob/5b95725dc4410634a658bda9aa59188eaeaf87ea/rq/job.py#L41 The API should be as...

Yes, I agree. Actually adding a success/failure callback is high on my priority list. It would be nice to be able to do something like `queue.enqueue(foo, on_success=bar, on_failure=baz)`. I haven't...

At the moment, if a job fails, we don't do anything with jobs that depends on the successful completion of the first job. In fact, the depending jobs are never...

> Would something like below work as the on_failure callback to actually enqueue the dependent jobs? Yes, you could use `on_failure` callback to enqueue dependent jobs if you wish to....

@caffeinatedMike that's because `queue.enqueue_dependents()` checks whether or not each job's [dependencies are met](https://github.com/rq/rq/blob/7be119068f31db165f8f3fea48d34a00ab587c02/rq/queue.py#L632) before enqueueing them. Remember that one job can have multiple dependencies. What we can do is add...

> I'm actually working on tests for the the official support of Dependency(..., allow_failure=True) functionality from PR https://github.com/rq/rq/pull/1611. I'm about to open up a PR that includes updates to that...

Oh ok, I wasn't aware of this. Will reopen the issue.