Selwin Ong

Results 512 comments of Selwin Ong

Thanks for the PR. I think at any one time, a job can only exist in one registry. When a job is moved to `StartedJobRegistry`, it should also be removed...

> It is when you enqueue, it's just up a level in the call stack: I meant when a job is popped off the queue and moved to `StartedJobRegistry` (when...

@alella @joshcoden thanks for explaination. It is indeed working as expected. I misread this because the the code around this part is not symmetric. Can you create a `job.move_to_started_job_registry()` method...

I like this idea a lot! RQ has been getting more complicated with each arg/kwarg added so having a centralized config object would be nice. If I may suggest, open...

> oops, now i have done it for all components in rq. Haha xD. I'll try to find the time to review it.

The ideal scenario would be for `fakeredis` to support all commands for the library it's mocking (i.e Redis), as it's their responsibility to properly mimic the library they're mocking. Having...

I like the idea of workers writing to `stdout` and `stderr`, think should be achievable by tweaking the default logging configuration. I'm not sure about saving `stdout` and `stderr` it...

@vladislavkoz Can this be reliably reproduced? Does this only happen when you're running `SimpleWorker` or when using FakeRedis? Can you check if adding an exception handler to to thread solves...

At the moment raising an exception is the only way to fail a job. I'm open to ideas.

Starting from version 1.5.0, RQ allows you to [configure retries](http://python-rq.org/docs/exceptions/). `queue.enqueue(my_func, retry=Retry(max=3, interval=60))` So if you want RQ to retry your function, simply raise an exception within your function.