Sam Clegg

Results 1132 comments of Sam Clegg

It could be that the expectations were built with llvm 14 and using llvm 13 can produce slightly different results. It looks like we test with 10 and 14: https://github.com/WebAssembly/wasi-libc/blob/957c7113c36c6d8c668fcf1d2bdd01b84e2e2530/.github/workflows/main.yml#L12...

Interesting point regarding the call to `free` on thread exit. While the does look like real issue it doesn't look like it related to this example since it only applies...

Could you share the full failing command line along with the full error output? (Perhaps just re-run `make` and attache the entire output?)

Can you try running that failing command but adding `-E` to get the pre-processed output? When I do this and I look at the preprocessed output the first occurrence of...

Yes, perhaps that is good idea. At least there needs to be an easy way to disable it .. its also fragile in the face of changing llvm versions.

These days its called `EXTRA_CFLAGS` I believe: https://github.com/WebAssembly/wasi-libc/blob/main/Makefile#L11

Yes, it looks like its specifically this line: https://github.com/WebAssembly/wasi-libc/pull/429/files#r1290434731.

Fixing doesn't look easy because it hides metadata in the first N bytes of its allocation.

I think that actual alignment will depend on alignof(struct map) since we do a `+= 1` on the result of malloc. we should confirm that is still 16byte sligned. I...

Given that wasm-libc's mmap is known is fake and non-optimal, perhaps we can see it as a stop gab for folks who don't want to take the extra time to...