Sam Clegg

I can give it go.. I need to learn more binaryen codebase stuff..

I can give it go.. I need to learn more binaryen codebase stuff..

Sounds reasonable that we should at least document this. For (1): Perhaps we should phrase it as "these are the compilers and environments where wasm2c is know build/run". Currently the...

> * wasm2c-generated sources still include standard headers such as and , but I guess I can sed my way to rewrite them, provided the functions they are expected to...

Looks like an easy fix. I'm confused why this isn't causing a built failure during CI. I will take a look.

Odd .. I can see wasm-rt-impl.c being compiled just fine by the github CI https://github.com/WebAssembly/wabt/runs/3257150141#step:10:18.

Does it make sense to name active segments? Can the name be used anywhere?

Actually in wasm-ld / emscripten we use make use of names for active elem segments so I think for completeness its worth fixing.

The issue relates to whether bulk memory is enabled. If I enable bulk memory on the failing command the problem goes away: ``` $ wat2wasm with-names.wat -o with-names.wasm --enable-bulk-memory ```...

I tested this change with the current emscripten, running all of core2 and other suites.