Sam Clegg
Sam Clegg
Ok, I'm going to close this issue since the answer seems to be "Yes"
I believe this is fixed by #39
@Daft-Freak can you confirm that this change doesn't break any of the existing SDL2 tests in the emscripten?
> @keithw Seems there are a few unrelated test failures after pulling in the latest testsuite, eg some elem-type mismatches. I've been working on a PR to update the testsuite...
https://github.com/WebAssembly/wabt/pull/2054
Sorry I meant to write `>>> 2`. The triple right shift is an unsigned shift (which is want) and the double right shift is a signed shift (which don't work...
If this is not in performance critical code you could just use a divide by 4 operation in all cases and keep the code simple.
Any place `>>` or `>>>` is used on a pointer value would need to be fixed. I don't know if `var src = pixels >> 2` is the only one.
Apologies @shravanrn, I was away at the CG meeting and I'm out sick this week. Lets try to get this landed somehow next week.
We should try to have binaryen CI running on the same linux version to catch these before they land. The build machine in question is running Ubuntu/Bionic