Sam Clegg

Results 1119 comments of Sam Clegg

Thanks Keith! Those all sounds like reasonable things (except maybe the last one :) Oh, I didn't know about w2c2. Link for reference: https://github.com/turbolent/w2c2 Regarding splitting output into multiple C...

There are also existing fuzzers in for parts wabt at least (e.g. parsers and validations). See https://github.com/google/oss-fuzz/tree/master/projects/wabt

> > Regarding splitting output into multiple C files. I agree that could be a good idea, but I think one file per function might be a little too much....

> There is also [wasm-to-rust](https://github.com/CryZe/wasm-to-rust) though it seems inactive now. > > I've been thinking that a higher-level target might also make sense as wasm itself goes in that direction,...

What do you think about renaming this PR to "wasm-interp: Add multi-module support"?

> wasi is working now. and i change unordered_map and the file fallback. > > I really tried to make the arguments work, but I would need another argument to...

Can you rebase now that the bulk memory change has landed?

I'd rather not depend on emscripten or wasi-sdk here. I think having them checked in here as wat files makes more sense, perhaps with script that can be used to...

Adding `-DCMAKE_OSX_DEPLOYMENT_TARGET=10.12` to the Makefile would be an easy fix yes. We should do that.

I don't see any downside using `-DCMAKE_OSX_DEPLOYMENT_TARGET=10.12`. As long as llvm itself can be built with no issue). @jfizz do you want to send a PR?