Sam Clegg
Sam Clegg
The term LTO normally refers to a specific thing which `-flto` which means compilation/optimization at link time. I believe what you are talking about here is normal linker DCE (dead...
> Thanks for taking a look. There's a good chance I'm using the wrong terms everywhere! I'm not familiar with this whole toolchain at all. I used lto only because...
For `__stdio_exit` it looks like there is a dummy version in `exit.c` and the real version should only be included if `__stdio_exit_needed` is referenced. The problem is that I imagine...
If you can find a way to do what you describe that would be great. I am not aware of any way to achieve that though.
So here we are updating from 18.1.0rc to 18.1.1? (Can you mention both these versions in the PR title). I'm not sure why ever pinned to an `rc` version but...
Yes, since wasi-sdk doesn't currently support exceptions we should probably be building `libc++abi.a` and `libc++.a` with `-fno-exceptions`. Would you like to send a patch?
It looks like do already build with `-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF` and `-DLIBCXX_ENABLE_EXCEPTIONS=OFF`, but I guess that is somehow not the same as `-fno-exceptions`?
Which version of wasi-sdk are you using? Looking at the wasi-sdk-20 I don't see any references to __cxa_allocate_exception in libc++-abi.a: ``` $ llvm-nm wasi-sdk-20.0/share/wasi-sysroot/lib/wasm32-wasi/libc++abi.a | grep __cxa_allocate_exception ```
> If possible, could you share a link that shows the changes to upstream llvm that were required? Doh! I saw you did that already right in the PR description,...
> @sunny-g targeting WASIX instead of just WASI might reduce the changes needed to LLVM, but the result would only work in WASM runtimes with WASIX support -- AFAICS that...