Sam Clegg

Results 1110 comments of Sam Clegg
trafficstars

> Would it be difficult to add back in here? Asking upstream may be worth doing, but it'd be nice if we could do something easy for now. Ah.. sadly...

`__extenddftf2` should be defined in compiler-rt (llvm-project/compiler-rt/lib/builtins/extenddftf2.c). Do you know where you compiler-rt library is coming from? Can you check it for that symbol? The version of compiler-rt that ships...

`wasm-ld` doesn't add any libraries automatically. Its up the driver (normally clang, or emcc) to add those. I'd be very surprised if compiler-rt was not being included by your the...

Maybe `wasm32-wasi/lib/libcompiler_builtins-a0294efb55e060eb.rlib` is just out of date? Also, shouldn't the linker report `__extenddftf2` as undefined at build time or is rust using the `--allow-undefined` linker flag to just ignore any...

Yes I see `--allow-undefined` in the link flags. That seems unfortunate since it delays these types of errors until runtime.

So this seems like a rust issue and not a wasi-sdk issue. Maybe open an issue there?

In the short term you might also want to just go with the `LIBSQLITE3_FLAGS="-DLONGDOUBLE_TYPE=double"` solution since using 128bit long double is expensive in terms of both code size and performance...

I agree it seems wrong that rust doesn't include these functions in its compiler-rt in this case. However I does seem like a rust toolchain issue, not a wasi-sdk one,...

Regarding getting the name of libcompiler-rt you can use `clang -print-libgcc-file-name` (verified that this works with wasi-sdk).