Sam Clegg

Results 1093 comments of Sam Clegg
trafficstars

I started working on this last week while travelling. Looks possible. Will post a PR soon. @binji did you start on this already?

I started work on a C++ wrapper but didn't get very far IIRC

And it would make sense to you to run it as part of `wasm-validate`?

We can't land this until emscripten starts passing the full imports object: https://github.com/emscripten-core/emscripten/pull/17806

Yeah, we shouldn't be including them. I guess we should disable those targets in the release builders (maybe even disable all testing? we also don't want to ship the unittest...

Looks like a bug in lld. It seems to effect both `wasm-ld` and `ld.lld`. `clang -o foo%/a.out test.c` works but `clang -o foo%/a.out test.c -fuse-ld=lld` fails in the same way...

Did you try with lld (i.e. `-fuse-ld=lld`)?

IIUC the two module maps in wasi-sdk are built directly from llvm and not maintained by us: ``` ./lib/clang/10.0.0/include/module.modulemap ./share/wasi-sysroot/include/c++/v1/module.modulemap ``` I'm not sure how they get built but I...

The wasm binary generated by the linker should contain features section which contains bulk memory. I think the correct fix here is to pass `--detect-features` to wasm-opt. @tlively should find...