Sam Clegg

Results 1473 comments of Sam Clegg

Thanks for the repro instructions. I'll try an see it I can reproduce tomorrow. A couple questions/pointers. - Is there some reason you specify the `onRuntimeInitialized` override in a different...

This is kind of unfortunate. Ideally we would just use `new URL(import.meta.url)` since we know we are trying to load the same file that is currently running.... however that apparently...

Does `new URL` with `import.meta.url` not include the `blob:https://` part? What is `import.meta.url` in your case?

I did look into this a while back and ran into the issue that we currently exports a synchronous fetch API, which Fetch does not support.. so we would either...

We currently rely on sync xhr both on the main thread and on our workers / pthreads. If we want to move away from XMLhttpRequest, the first project would be...

I think we still want to keep this open until the Emscripten Fetch API is updated. We have a PR for that open, but it still has some work to...

> I am currently implementing a work-around for this issue in my code base. It seems that the proposed solution #21199 has gone nowhere. I propose a minimal changeset implementing...

> For `test_dlfcn_self (test_core.core0)` I am not sure why `__data_end` is not exported now thinking A rebase should fix that issue I think.

Whats the deal with `CMAKE_STRIP FALSE`... if that doesn't work can you open a bug report.. and leave a comment in the place where we disable this?

> The `CMAKE_STRIP` issue I saw in [pyodide/pyodide#2169](https://github.com/pyodide/pyodide/pull/2169) when building a `pybind11` extension: https://github.com/pybind/pybind11/blob/v2.9.1/tools/pybind11Common.cmake#L399-L411 > > Simply did not work with what it picked for `CMAKE_STRIP`. Do you have your...