Sam Clegg

Results 1477 comments of Sam Clegg

@brendandahl do we not have any tests that return empty string from C++?

Agree that adding 35 new API calls also seems like a bad idea :-/ Maybe we should at at least add a new generic API for this? i.e. if we...

I'm afraid I don't have an answer for you now. I think some more thought/discussion needs to go into this. Lets involve @juj and @kripken and see what they think....

> Thank you @juj for the review and comments. I am personally in full agreement with the approach. @sbc100 what do you think? > Fair enough. > The only think...

To get the codesize expectation match can you try the following commands: ``` $ emsdk install tot $ ./emcc --clear-cache $ ./tools/maint/rebaseline_tests.py ``` If you run those command one `upstream/main`...

Once the codesize tests pass I think we can land this.

I can download the PR and upload the matching code size results for you.

> > I can download the PR and upload the matching code size results for you. > > That would be awesome. I wished I understood why it doesn't work...

`source /usr/local/emsdk/emsdk_env.sh` should work just fine. If you want to be able to just set `EM_CONFIG` then you need to make sure your python3 install has psutuil installed. You can...

> * as a result the "latest" version ends up being under `/usr/local/emsdk/upstream/emscripten` Are you installing "latest" or "tot" ? For rebaslining tests you you really need "tot". You should...