Wenjun Ruan

Results 268 comments of Wenjun Ruan

> BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5: > > 1. We keep both versions of jUnit dependencies and migrate those...

> > > BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5: > > > > > > 1. We keep both versions...

@BenJFan I remember we have fixed this on dev branch?

> Hi, @ruanwenjun and @BenJFan , I'm afraid the git workflow might need some improvement. > > I tried the failed command in my machine (MacOS), it works. > >...

+1, it would be great if we can upgrade to junit 5+

> I think we also need to redesign the state machine for task instance and workflow instance. Otherwise the logic will be confusing and easy to result in bugs when...

> Have you read the docs? Have you tried it out? I have read the doc, find I can add sub command by following way In this way, I need...

I am -1 to this DSIP. In standalone mode, users can directly use the local file system. In cluster mode, users can use distribution file system or some shared file...

> ## [![Quality Gate Passed](https://camo.githubusercontent.com/5889b9ad78888934928f8f18bb6431c836cd7cabe6c3a6a60a1a01434d67cfdb/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d7061737365642d323070782e706e67)](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15554) **Quality Gate passed** > Issues ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [42 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15554&resolved=false&inNewCodePeriod=true) ![](https://camo.githubusercontent.com/6e7f22e3d7f9764d9cfb28e3b8ee5ebb5f711c5bb2dcec8a6db6b0d958d63134/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67) [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15554&metric=new_accepted_issues&view=list) > > Measures ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15554&resolved=false&inNewCodePeriod=true) ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [62.8% Coverage on New...

Does the task be killed at ds? Seems the workflow status is ready kill