seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Improve][UT] Upgrade junit to 5.+

Open ashulin opened this issue 3 years ago • 5 comments

Search before asking

  • [X] I had searched in the feature and found no similar feature requirement.

Description

Right now, we still use junit 4.+ in our repo, I hope we can upgrade to Junit 5.+, then we can easy to write the UT, JUnit 5 provide some useful feature, e.g. @ParameterizedTest, @EnabledOnOs,...

Currently we have a small number of test cases and it is easy to upgrade dependencies.

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

ashulin avatar Jul 28 '22 04:07 ashulin

CC @Hisoka-X @CalvinKirs @ruanwenjun

ashulin avatar Jul 28 '22 04:07 ashulin

+1,5 have many highlights

CalvinKirs avatar Jul 28 '22 04:07 CalvinKirs

+1

EricJoy2048 avatar Jul 28 '22 05:07 EricJoy2048

+1, it would be great if we can upgrade to junit 5+

ruanwenjun avatar Jul 28 '22 07:07 ruanwenjun

Because Testcontainers are tightly coupled with JUnit4, we can't completely remove junit4, maybe we need a check style rule to banned the import of junit4 class.

ashulin avatar Jul 31 '22 17:07 ashulin