dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement] Audit log Improvement

Open qingwli opened this issue 1 year ago • 5 comments

  • close #15423

qingwli avatar Feb 02 '24 07:02 qingwli

PTAL @ruanwenjun @SbloodyS @rickchengx @EricGao888

qingwli avatar Feb 06 '24 03:02 qingwli

Codecov Report

Attention: Patch coverage is 57.52961% with 251 lines in your changes are missing coverage. Please review.

Project coverage is 39.38%. Comparing base (efbffac) to head (46bec40).

:exclamation: Current head 46bec40 differs from pull request most recent head 8e0613b. Consider uploading reports for the commit 8e0613b to get more accurate results

Files Patch % Lines
.../dolphinscheduler/common/enums/AuditModelType.java 0.00% 44 Missing :warning:
...phinscheduler/common/enums/AuditOperationType.java 0.00% 42 Missing :warning:
...ache/dolphinscheduler/api/audit/OperatorUtils.java 53.75% 26 Missing and 11 partials :warning:
...cheduler/api/audit/operator/BaseAuditOperator.java 83.33% 8 Missing and 6 partials :warning:
...api/audit/operator/impl/TaskAuditOperatorImpl.java 7.69% 12 Missing :warning:
...nscheduler/api/dto/auditLog/AuditModelTypeDto.java 0.00% 12 Missing :warning:
.../audit/operator/impl/ProcessAuditOperatorImpl.java 47.36% 3 Missing and 7 partials :warning:
...audit/operator/impl/ScheduleAuditOperatorImpl.java 69.56% 4 Missing and 3 partials :warning:
...eduler/api/dto/auditLog/AuditOperationTypeDto.java 0.00% 7 Missing :warning:
...dit/operator/impl/DatasourceAuditOperatorImpl.java 16.66% 5 Missing :warning:
... and 24 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15554      +/-   ##
============================================
+ Coverage     39.24%   39.38%   +0.13%     
- Complexity     4911     4981      +70     
============================================
  Files          1323     1347      +24     
  Lines         45191    45641     +450     
  Branches       4812     4892      +80     
============================================
+ Hits          17736    17976     +240     
- Misses        25573    25733     +160     
- Partials       1882     1932      +50     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 06 '24 03:02 codecov-commenter

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 20 '24 06:02 sonarqubecloud[bot]

Hi @rickchengx I have solved conflicts and show some imges in #15423

qingwli avatar Feb 20 '24 07:02 qingwli

PTAL @rickchengx @EricGao888 @SbloodyS @ruanwenjun @caishunfeng @zhongjiajie

qingwli avatar Feb 26 '24 08:02 qingwli

PTAL @ruanwenjun

qingwli avatar Apr 15 '24 03:04 qingwli