Artem Fetishev

Results 12 comments of Artem Fetishev

This feature has been included into [v1.130.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.130.0).

> AFAIK, and according to the mentioned comment, this error is returned not only for -search.maxUniqueTimeseries, but for some other limits as well. Hence, this change becomes misleading instead of...

@hagen1778, per our offline discussion changed the error message to the one that has been originally suggested by @valyala. PTAL

> Are you looking into having these articles by email ? https://victoriametrics.com/blog/ Yes!

Look like this has been done. Thank you.

> I suggest to add new metrics only with reasonable purpose. Since VictoriaMetrics is a database, one of its primary purposes is storing the data, I believe that these new...

> I think most of these new metrics have sense for debugability purposes. But we need to make sure they're indeed actionable for users. That being said, we should verify...

Ok, per another discussion with @hagen1778 and @valyala we have decided to keep the NaN check as is and do not drop them in vminsert. The assumptions are the following:...

@f41gh7 / @hagen1778 I have removed stale nans. At this point the PR is ready to be merged. Please take a look.