control_toolbox
control_toolbox copied to clipboard
ros-controls
Line 342 of pid.cpp If an error or dt=0, occurs you return zero but don't update the stored command. I saw this causing issues in simulation I suggest the following:...
I tried to build control_toolbox on Windows (MSVC) (using `colcon build`) It gives me this LNK1181 error. ``` Building Custom Rule C:/Program Files/ros2_ws/src/control_toolbox/CMakeLists.txt test_load_low_pass_filter.cpp LINK : fatal error LNK1181: ���������ļ���Release\low_pass_filter.lib��[C:\ProgramFiles\ros2_ws\build\control_toolbox\test_load_low_pass_filter.vcxproj]...
An automated scheduled build failed on `ros2-master`: https://github.com/ros-controls/control_toolbox/actions/runs/11089291557
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "github-actions[bot] avatar"){kind=avatar}
``` 2024-09-12T02:24:56.9259275Z test 4 2024-09-12T02:24:56.9259495Z Start 4: test_low_pass_filter 2024-09-12T02:24:56.9259701Z 2024-09-12T02:24:56.9263997Z 4: Test command: /usr/bin/python3 "-u" "/opt/ros/jazzy/share/ament_cmake_test/cmake/run_test.py" "/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/control_toolbox/test_results/control_toolbox/test_low_pass_filter.gtest.xml" "--package-name" "control_toolbox" "--output-file" "/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/control_toolbox/test_results/control_toolbox/test_low_pass_filter.txt" "--command" "/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/control_toolbox/test_low_pass_filter" "--ros-args" "--params-file" "/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/src/ros-controls/control_toolbox/test/control_filters/test_low_pass_filter_parameters.yaml" "--" "--gtest_output=xml:/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/control_toolbox/test_results/control_toolbox/test_low_pass_filter.gtest.xml" 2024-09-12T02:24:56.9268243Z 4:...
An automated scheduled build failed on `ros2-master`: https://github.com/ros-controls/control_toolbox/actions/runs/14436915781
We have a [`JointSaturationLimiter`](https://github.com/ros-controls/ros2_control/blob/master/joint_limits/src/joint_saturation_limiter.cpp) that limits positions, velocities, and acceleration for the arms. Can we reuse that logic also here, by extending the limiter with a new `on_enforce` method to...
An automated scheduled build failed on `humble`: https://github.com/ros-controls/control_toolbox/actions/runs/14234402002
Needs https://github.com/ros-controls/ros2_control_ci/pull/216 to be fixed first.
### **Overview** This PR adds three new anti-windup techniques: back‑calculation, the conditioning technique, and conditional integration. It also adds a saturation feature for the PID output. New parameters have been...
