Robert Bastian

Results 390 comments of Robert Bastian
trafficstars

As a first step, can we use identity federation with allowlisted repos?

I totally support this for serde borrowing, which is broken for `Cow`. > Might be able to reduce stack size: Box instead of Vec for the owned type I don't...

https://github.com/unicode-org/icu4x/blob/3694bfef1bae9e44eda3648574875f5c358eafbe/components/plurals/src/provider.rs#L371

I *think* I made my arguments in terms of the old API (@sffc it would be really nice if that could be deleted, I still don't understand which code will...

#5534 to address observation 3 and decouple `CustomTimeZone` from neo fields.

I've mocked this up in #5535

> A third-party type that doesn't have metazone information baked into it could use MetazoneCalculator inside of its impl GetInput. But it can't, because in the `impl GetInput` there's no...

What do you think about the pattern I'm suggesting for IANA -> BCP-47 mapping?

I will wait until the legacy datetime API is deleted before commenting here.

We don't generate diplomat-generated code. I think it was @sffc who opposed running `dart format` and said that it should just try to be readable. Files should be marked as...