Robert Bastian

Results 384 comments of Robert Bastian
trafficstars

We don't need skips, just `// @generated` in the first line of each generated file.

> My objection to dart format was not the formatting, but that I didn't want diplomat-gen to require dart to be installed (at a particular version, etc). That's the same...

The `format_generated_files` flag is unstable, but the stable behaviour is to not format generated files. This is what is already happening for baked data. > My ideal outcome is that...

Just for completeness: the reason why I consider this separate from #3054 is that it can be solved entirely in the `icu4x-docs` repo, we can go full web-design there and...

This removes all `Etc/` time zones except for `Etc/GMT+12`, as that time zone is actually [not used anywhere](https://en.wikipedia.org/wiki/UTC%E2%88%9212:00#:~:text=A%20number%20of,UTC%E2%88%9212%3A00.) outside nautical time. ![Image](https://github.com/user-attachments/assets/1a1e9b47-d094-43fd-bf0f-92dec69189ae) ![Image](https://github.com/user-attachments/assets/0348a4c2-f519-416c-9c7c-c997479c0f57)

`core::net` does not contain `ToSocketAddrs`. It would be nice if this crate could reexport the `core` types, so that other crates that are using this one automatically get updated to...

Even if PHP and Wolfram Alpha agree on this, I don't think this is actually going to be the time in Chicago then (prove me wrong!). Times that far into...

> 1. The [contract](https://doc.rust-lang.org/std/default/trait.Default.html) of impl Default is to fill in default values for fields when there are reasonable default values. But these are opaques, not bag-of-field structs, and impl...

The issue title misrepresents what's happening. There is never any "data loading" in a `Default` impl. Even in `SentenceSegmenter` which you use as an example, there is not: ```rust impl...

- @sffc Default should be no different from any other impl we add - @zbraniecki: Aligned Two positions: - @robertbastian: If it has `new()` and not also `new_()` it should...