Robert Bastian
Robert Bastian
+1 on using `_utf8` instead of `_bytes`.
What about this pattern: ```rust pub struct Era(pub TinyStr16); impl From for Era { fn from(x: TinyStr16) -> Self { Self(x) } } impl FromStr for Era { type Err...
This is done for all stable components and utils, except for the datetime and plurals reference and runtime modules.
No change since the last update from me.
Again, https://github.com/unicode-org/icu4x/issues/4931#issuecomment-2354860616
I support this, but I don't think this would have helped in #4191. The problem there was that different ICU minor releases got mixed in the presence of baked data,...
Actually, do we want to call them `data_unstable`, or `data_structs_unstable`? They don't define providers.
Maybe we should be explicit about unstable modules and put them all behind an `unstable` feature. We can use [`instability`](https://docs.rs/instability/latest/instability/attr.unstable.html) to mark them in docs. Our internal dependencies would enable...
It does not need to be enabled by default! The feature would make the `pub(crate)` provider module `pub`, and as such it would be needed by basically just `icu_provider_source`.